[geom][mini] Disabling (temporarily) c++20 [[unlikely]] compiler hint. #17413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agheata
changed the title
agheata
force-pushed
the
mini_warn_likely
branch
from
ca4a086 to
08d7754
Compare
Test Results 18 files 18 suites 4d 3h 22m 10s ⏱️ For more details on these failures, see this check. Results for commit 0edf4b4. ♻️ This comment has been updated with latest results. |
bellenot
requested changes
Jan 17, 2025
bellenot
approved these changes
Jan 17, 2025
agheata
force-pushed
the
mini_warn_likely
branch
from
9c8b003 to
42816fd
Compare
agheata
force-pushed
the
mini_warn_likely
branch
from
645df6d to
0edf4b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Disables a c++20 [[unlikely]] hint to prevent a
-Wattributescompilation warningChanges or fixes:
I just commented, not removed entirely, to disable the warning on c++17 or less mode. We have
R__unlikely, which cannot be used in a multiple-branch statement.Checklist:
This PR fixes #