Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpad] Fix Debug Assertion Failure in libGpad #17249

Merged

Conversation

bellenot
Copy link
Member

Fix the following error in Debug mode with Runtime Check on Windows:
Debug Assertion Failed!
Expression: vector subscript out of range

Fix the following error in Debug mode with Runtime Check on Windows:
Debug Assertion Failed!
Epression: vector<bool> subscript out of range
@bellenot bellenot self-assigned this Dec 11, 2024
@bellenot bellenot requested a review from couet as a code owner December 11, 2024 13:53
Copy link

Test Results

    18 files      18 suites   4d 3h 56m 24s ⏱️
 2 662 tests  2 662 ✅ 0 💤 0 ❌
46 198 runs  46 198 ✅ 0 💤 0 ❌

Results for commit 2196180.

Copy link
Member

@couet couet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bellenot bellenot merged commit 456d542 into root-project:master Dec 12, 2024
20 of 21 checks passed
@bellenot bellenot deleted the fix-gpad-subscript-out-of-range branch December 12, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants