Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyROOT] Retain C++ memory ownership for TStyle #16932

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Nov 13, 2024

Similar to 18a7c1f, since also any instantiated TStyle is owned by ROOT.

Closes #16918.

See:
https://github.com/root-project/root/blob/master/core/base/src/TStyle.cxx#L212

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! Could you also add the reproducer from the issue as a test? This way once hopefully we work our way out of the memory regulation logic we can make sure also this case is covered

Similar to 18a7c1f, since also any instantiated TStyle is owned by
ROOT.

Closes root-project#16918.
@guitargeek
Copy link
Contributor Author

Sure! I added the test

Copy link

Test Results

    19 files      19 suites   3d 23h 24m 51s ⏱️
 2 665 tests  2 665 ✅ 0 💤 0 ❌
48 742 runs  48 742 ✅ 0 💤 0 ❌

Results for commit 283164f.

@dpiparo dpiparo merged commit cfc493d into root-project:master Nov 14, 2024
22 checks passed
@guitargeek guitargeek deleted the issue-16918 branch November 14, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash in finalization
3 participants