Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix bug in tab completion with cv qualifiers #16924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ferdymercury
Copy link
Contributor

@ferdymercury ferdymercury commented Nov 13, 2024

This Pull request:

Changes or fixes:

Fixes https://its.cern.ch/jira/browse/ROOT-6636 reported by @olifre

Sibling PR in root-project/roottest#1218

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

Copy link

github-actions bot commented Nov 13, 2024

Test Results

    19 files      19 suites   4d 15h 8m 38s ⏱️
 2 677 tests  2 668 ✅ 0 💤  9 ❌
48 946 runs  48 923 ✅ 0 💤 23 ❌

For more details on these failures, see this check.

Results for commit 5cc9349.

♻️ This comment has been updated with latest results.

@hahnjo
Copy link
Member

hahnjo commented Nov 14, 2024

This should definitely have (a) new test(s) added...

@hageboeck hageboeck assigned devajithvs and hahnjo and unassigned dpiparo Nov 14, 2024
ferdymercury added a commit to ferdymercury/roottest that referenced this pull request Nov 14, 2024
ferdymercury added a commit to ferdymercury/roottest that referenced this pull request Nov 14, 2024
@ferdymercury
Copy link
Contributor Author

ferdymercury commented Nov 14, 2024

Just added a test.
I am confused though wrt why it says unqualified-id with the semicolon.

@hahnjo
Copy link
Member

hahnjo commented Nov 15, 2024

@ferdymercury I think you need to debug the test locally, it's too resource consuming to do this via the GitHub CI...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants