Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hist] Remove complex-arg functions from context menu #16920

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

ferdymercury
Copy link
Contributor

@ferdymercury ferdymercury commented Nov 13, 2024

Fixes https://its.cern.ch/jira/browse/ROOT-10883

It does not make much sense to use a context menu and then copy from the terminal the hex pointer 0x123445 int-value from other histogram pointers, you would directly use the terminal then and tab-completion.

Sibling PR in root-project/roottest#1216

Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bellenot
Copy link
Member

@ferdymercury FYI, if ROOT and rootest PRs have to be checked together, they should have the same branch name, so you can run the proper roottest with its matching changes in master

@dpiparo
Copy link
Member

dpiparo commented Nov 13, 2024

yes I think the root PR was created before the roottest PR, but it's not a problem at all (thanks for these nice changes!). I am cancelling this build and restarting it in order for it to pick the sibling PR.

@dpiparo dpiparo closed this Nov 13, 2024
@dpiparo dpiparo reopened this Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

Test Results

    19 files      19 suites   4d 17h 26m 53s ⏱️
 2 665 tests  2 664 ✅ 0 💤 1 ❌
48 742 runs  48 741 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 8884b40.

♻️ This comment has been updated with latest results.

dpiparo pushed a commit to root-project/roottest that referenced this pull request Nov 14, 2024
@dpiparo dpiparo merged commit 0b9cdbc into root-project:master Nov 14, 2024
20 of 22 checks passed
@ferdymercury ferdymercury deleted the hcont branch November 14, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants