-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hist] Remove complex-arg functions from context menu #16920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@ferdymercury FYI, if ROOT and rootest PRs have to be checked together, they should have the same branch name, so you can run the proper roottest with its matching changes in master |
yes I think the root PR was created before the roottest PR, but it's not a problem at all (thanks for these nice changes!). I am cancelling this build and restarting it in order for it to pick the sibling PR. |
Test Results 19 files 19 suites 4d 17h 26m 53s ⏱️ For more details on these failures, see this check. Results for commit 8884b40. ♻️ This comment has been updated with latest results. |
Fixes https://its.cern.ch/jira/browse/ROOT-10883
It does not make much sense to use a context menu and then copy from the terminal the hex pointer 0x123445 int-value from other histogram pointers, you would directly use the terminal then and tab-completion.
Sibling PR in root-project/roottest#1216