Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buffer overflow when opening the Fit Panel #16913

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

langufo
Copy link

@langufo langufo commented Nov 12, 2024

Fedora 40 build for 6.32.06 crashes when opening the parameter dialog of the Fit Panel
with a "buffer overflow detected" message.

Such behavior is caused by calls to strlcpy with an incorrect size of the destination buffer,
which this PR fixes.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@bellenot bellenot self-assigned this Nov 13, 2024
Copy link

Test Results

    19 files      19 suites   4d 14h 23m 26s ⏱️
 2 665 tests  2 664 ✅ 0 💤 1 ❌
48 742 runs  48 741 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 611fa16.

Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bellenot bellenot merged commit 9d526de into root-project:master Nov 13, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants