Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ntuple] move RColumnElement out of anonymous namespace #16907

Closed
wants to merge 1 commit into from
+3 −4
Closed

[ntuple] move RColumnElement out of anonymous namespace #16907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tree/ntuple/v7/src/RColumnElement.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,6 @@
dst[i] = sval;
}
}
} // namespace

// anonymous namespace because these definitions are not meant to be exported.
namespace {

using ROOT::Experimental::EColumnType;
using ROOT::Experimental::Internal::RColumnElementBase;
Expand Down Expand Up @@ -882,7 +878,7 @@
// (which should never happen).
RColumnElementTrunc() : RColumnElementBase(kSize, 0) {}

void SetBitsOnStorage(std::size_t bitsOnStorage) final

Check warning on line 881 in tree/ntuple/v7/src/RColumnElement.hxx

View workflow job for this annotation

GitHub Actions / alma8 LLVM_ENABLE_ASSERTIONS=On 

‘void {anonymous}::RColumnElementTrunc<T>::SetBitsOnStorage(std::size_t) [with T = double]’ declared ‘static’ but never defined [-Wunused-function]

Check warning on line 881 in tree/ntuple/v7/src/RColumnElement.hxx

View workflow job for this annotation

GitHub Actions / alma8 LLVM_ENABLE_ASSERTIONS=On 

‘void {anonymous}::RColumnElementTrunc<T>::SetBitsOnStorage(std::size_t) [with T = float]’ declared ‘static’ but never defined [-Wunused-function]
{
const auto &[minBits, maxBits] = GetValidBitRange(EColumnType::kReal32Trunc);
R__ASSERT(bitsOnStorage >= minBits && bitsOnStorage <= maxBits);
Expand Down Expand Up @@ -1092,19 +1088,22 @@

RColumnElementQuantized() : RColumnElementBase(kSize, 0) {}

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wunused-function"
void SetBitsOnStorage(std::size_t bitsOnStorage) final

Check warning on line 1093 in tree/ntuple/v7/src/RColumnElement.hxx

View workflow job for this annotation

GitHub Actions / alma8 LLVM_ENABLE_ASSERTIONS=On 

‘void {anonymous}::RColumnElementQuantized<T>::SetBitsOnStorage(std::size_t) [with T = double]’ declared ‘static’ but never defined [-Wunused-function]

Check warning on line 1093 in tree/ntuple/v7/src/RColumnElement.hxx

View workflow job for this annotation

GitHub Actions / alma8 LLVM_ENABLE_ASSERTIONS=On 

‘void {anonymous}::RColumnElementQuantized<T>::SetBitsOnStorage(std::size_t) [with T = float]’ declared ‘static’ but never defined [-Wunused-function]
{
const auto [minBits, maxBits] = GetValidBitRange(EColumnType::kReal32Quant);
R__ASSERT(bitsOnStorage >= minBits && bitsOnStorage <= maxBits);
fBitsOnStorage = bitsOnStorage;
}

void SetValueRange(double min, double max) final

Check warning on line 1100 in tree/ntuple/v7/src/RColumnElement.hxx

View workflow job for this annotation

GitHub Actions / alma8 LLVM_ENABLE_ASSERTIONS=On 

‘void {anonymous}::RColumnElementQuantized<T>::SetValueRange(double, double) [with T = double]’ declared ‘static’ but never defined [-Wunused-function]

Check warning on line 1100 in tree/ntuple/v7/src/RColumnElement.hxx

View workflow job for this annotation

GitHub Actions / alma8 LLVM_ENABLE_ASSERTIONS=On 

‘void {anonymous}::RColumnElementQuantized<T>::SetValueRange(double, double) [with T = float]’ declared ‘static’ but never defined [-Wunused-function]
{
R__ASSERT(min >= std::numeric_limits<T>::lowest());
R__ASSERT(max <= std::numeric_limits<T>::max());
fValueRange = {min, max};
}
#pragma GCC diagnostic pop

bool IsMappable() const final { return kIsMappable; }

Expand Down
Loading