[webgui] do not use Edge browser for headless by default #16770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While Microsoft does not allow to use headless mode by default, do not try to use it without explicit argument `--web=edge`
bellenot
approved these changes
Oct 28, 2024
Test Results 18 files 18 suites 3d 20h 23m 6s ⏱️ For more details on these failures, see this check. Results for commit 7346c18. ♻️ This comment has been updated with latest results. |
bellenot
reviewed
Oct 29, 2024
| fBatchExec = gEnv->GetValue((fEnvPrefix + "Batch").c_str(), "$prog --headless=old --no-sandbox $geometry --dump-dom $url"); | ||
| fHeadlessExec = gEnv->GetValue((fEnvPrefix + "Headless").c_str(), "$prog --headless=old --no-sandbox --disable-gpu $geometry \"$url\" &"); | ||
| // in interactive headless mode fork used to let stop browser via process id | ||
| fHeadlessExec = gEnv->GetValue((fEnvPrefix + "Headless").c_str(), "fork:--headless=new --no-sandbox --disable-gpu $geometry \"$url\""); |
There was a problem hiding this comment.
Suggested change
| fHeadlessExec = gEnv->GetValue((fEnvPrefix + "Headless").c_str(), "fork:--headless=new --no-sandbox --disable-gpu $geometry \"$url\""); | |
| fHeadlessExec = gEnv->GetValue((fEnvPrefix + "Headless").c_str(), "fork:--headless=old --no-sandbox --disable-gpu $geometry \"$url\""); |
While in headless mode browser not always correctly stopped, start Chrome/Edge/Firefox via wmic. In this case one got processid and can kill it
linev
force-pushed
the
edge_not_native
branch
from
7346c18 to
9311efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Microsoft does not allow to use headless mode by default,
do not try to use it without explicit argument
--web=edge