[ntuple] Fixes and cleanups for RRecordField and subclasses
#16764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For typed RField<std::pair<T1, T2>> and RField<std::tuple<ItemTs...>>, it is dangerous to accept user-created item fields because there is no check that the types match.
In C++, the order of evaluation of function arguments is unspecified. This could lead to problems in the constructors of RPairField and RTupleField where itemFields was both std::move'd and passed to the respective GetTypeList. (In practice, the base class constructor took itemFields as xvalue so it was only passing a pointer.) This cannot be solved when callign a base class constructor, so split attaching the item fields into a separate method.
Similar to taking a single std::unique_ptr by value to signal ownership handover, we should take containers thereof by value. This avoids having two overloads and requires the user to explicitly move the container of item fields instead of modifying it when passed by reference.
It was missing the trailing padding, which was covered up by the typed RField specializations overriding the fSize member. Convert them into assertions, which can only compare inequality because the alignment of RMapField and RSetField are pessimized since commit 49ef6f9.
pcanal
reviewed
Oct 28, 2024
Test Results 18 files 18 suites 3d 18h 38m 1s ⏱️ For more details on these failures, see this check. Results for commit bcc29e8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFieldconstructors, where the user could pass subfields into typedRField<std::pair<T1, T2>>andRField<std::tuple<ItemTs...>>without checks.RRecordFieldconstruction, related to unspecified order of evaluation of function arguments.unique_ptr's by value, to signal ownership handover.fSizecalculation inRRecordField::AttachItemFields, to have less (critical) logic in the typedRFieldconstructors.