Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full Chain Graphic Testing with Headless Chrome Browser #16322

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Full Chain Graphic Testing with Headless Chrome Browser #16322

wants to merge 18 commits into from

Conversation

DuesselbergAdrian
Copy link

@DuesselbergAdrian DuesselbergAdrian commented Aug 28, 2024 •
edited
Loading

This Pull request:

Changes or fixes:

DO NOT MERGE!! This PR tests the graphic test suite and includes installation of chrome in ROOT CI.

Checklist:

  • Make old svg, pdf, json, tests run on all platforms except windows
  • Install headless chrome browser in ROOT CI (Done for linux)
  • Enable new svg tests in roottest (Enabled for linux)
  • updated the references files for new svg (if necessary)
  • Deal with hanging web chrome browser (only problem on linux, works for 18 test, maybe try to increase number of tests)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

Test Results

    13 files      13 suites   3d 1h 46m 17s ⏱️
 2 971 tests  2 971 ✅ 0 💤 0 ❌
35 899 runs  35 899 ✅ 0 💤 0 ❌

Results for commit abbb7b0.

♻️ This comment has been updated with latest results.

@DuesselbergAdrian DuesselbergAdrian mentioned this pull request Aug 28, 2024
Open
@DuesselbergAdrian DuesselbergAdrian changed the title DO NOT MERGE Trigger test DO NOT MERGE Full chain graphic testing with headless chrome browser Aug 29, 2024
@DuesselbergAdrian DuesselbergAdrian changed the title DO NOT MERGE Full chain graphic testing with headless chrome browser DO NOT MERGE Full chain Graphic Testing with headless chrome browser Aug 29, 2024
@DuesselbergAdrian DuesselbergAdrian changed the title DO NOT MERGE Full chain Graphic Testing with headless chrome browser Full Chain Graphic Testing with Headless Chrome Browser Sep 2, 2024
@DuesselbergAdrian DuesselbergAdrian force-pushed the full-chain-testing branch 2 times, most recently from 91f31a4 to b372a9c Compare September 9, 2024 09:33
linev
linev reviewed Sep 12, 2024
View reviewed changes
.github/workflows/root-ci.yml
apt install -y wget
wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
apt install -y ./google-chrome-stable_current_amd64.deb
fi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Google Chrome is used here? Why not to use chromium - it typically provided in all distributions.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll change that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment I see only installation of chromium - where it used then?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need it to run the new graphic svg test in roottest. root-project/roottest#1179

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now. Does it works with roottest now?

Copy link
Author

@DuesselbergAdrian DuesselbergAdrian Sep 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For MAC the chrome/chromium installation is still missing. I think someone with authority has to do it.
The new svg tests with headless chrome browser are not hanging on MAC, at least on my machine. So after the installation it should be posisble to enabled all tests here.

For Linux the chromium installation is implemented, but here the headless browser is sometimes hanging.
That's why only 15 new svg tests are enabled. This is also the reason why I am currently differentiating between MAC and Linux platforms in my CMakeLists in roottest/graphics.

Yes in general there is a set of all test types, which is working on Linux and should also work on MAC after the chrome/chromium installation in the ROOT CI

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill probably have to regenerate some references, but that's it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linev linev linev approved these changes

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

@bellenot bellenot Awaiting requested review from bellenot

@jblomer jblomer Awaiting requested review from jblomer

@devajithvs devajithvs Awaiting requested review from devajithvs

Assignees

@DuesselbergAdrian DuesselbergAdrian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DuesselbergAdrian @linev @mdessole