Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add membership cancellation for Mollie #200

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Add membership cancellation for Mollie #200

merged 1 commit into from
Jul 18, 2024

Conversation

rrooij
Copy link
Contributor

@rrooij rrooij commented Jul 14, 2024

Very primitive way of cancelling subscriptions. Not a fancy solution but given the urgency I opted for a lesser-than-ideal approach.

@rrooij
Add membership cancellation for Mollie
efbd5f2 
Very primitive way of cancelling subscriptions. Not a fancy
solution but given the urgency I opted for a lesser-than-ideal
approach.
Gwildor
Gwildor approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@Gwildor Gwildor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please change the wording a bit in the button and the confirmation messages, as it's currently a bit confusing that this concerns Mollie memberships, not general memberships. Also the confirmation messages are now in English, instead of Dutch.

@rrooij rrooij merged commit 794a192 into main Jul 18, 2024
1 check passed
@rrooij rrooij deleted the feature/allow-mollie-cancel-from-admin branch July 18, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gwildor Gwildor Gwildor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrooij @Gwildor