Add membershipStatus to member revision #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gwildor
reviewed
Feb 24, 2024
This way history is kept for changing memberships, which is interesting to view membership history over time. The event listener responsible for this was already implemented in: src/EventSubscriber/EasyAdminEventSubscriber.php as it simply called the constructor of the MemberDetailsRevision and passes a Membership as its argument. Therefore just adding the field, a migration and changing the constructor to add this makes this work.
rrooij
force-pushed
the
feature/add-revision-history
branch
from
9f0d386
to
f982851
Compare
Gwildor
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way history is kept for changing memberships, which is interesting for viewing membership history over time.
The event listener responsible for this was already implemented in: src/EventSubscriber/EasyAdminEventSubscriber.php as it simply called the constructor of the MemberDetailsRevision and passes a Membership as its argument. Therefore just adding the field, a migration and changing the constructor to add this makes this work.