Add membershipstatus #154
Merged
Add membershipstatus #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The members lacked a status field which made it hard to keep track of whether members were ex-members, members, expelled, cancelled their membership etc. This introduces arbitrary fields of membership statuses that are being able to be set by the administrators. The migration makes a single membership type in advance which is called "Lid" (member) and everyone by default will be made member and get access to the login. You can make additional membership types which can't login to the system at all.
Gwildor
approved these changes
Feb 18, 2024
| public function setName(string $name): void { $this->name = $name; } | ||
|
|
||
| public function getAllowedAccess(): bool { return $this->allowedAccess; } | ||
| public function setAllowedAccess(bool $allowedAccess) { $this->allowedAccess = $allowedAccess; } |
There was a problem hiding this comment.
You're missing the void return type of the function here.
src/Entity/Member.php
Outdated
| return $this->currentMembershipStatus; | ||
| } | ||
|
|
||
| public function setCurrentMembershipStatus(?MembershipStatus $membershipStatus) { |
There was a problem hiding this comment.
Missing void return type here.
| /** @see UserInterface */ | ||
| public function getUsername(): string { return $this->id; } | ||
|
|
||
| /** @see UserInterface */ | ||
| public function getRoles(): array { | ||
| $roles = $this->roles; | ||
| $roles[] = 'ROLE_USER'; | ||
| if ($this->getCurrentMembershipStatus() === null || $this->currentMembershipStatus->getAllowedAccess()) { | ||
| $roles[] = 'ROLE_USER'; |
There was a problem hiding this comment.
What is the behaviour if the user has 0 roles? Will that not break things?
There was a problem hiding this comment.
The user always has the Anonymous/Public user role. And in the case of no roles, it will either deny access or add one of the roles to the array (as the roles property of Member is always an array by default)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The members lacked a status field which made it hard to keep track of whether members were ex-members, members, expelled, cancelled their membership etc.
This introduces arbitrary fields of membership statuses that are being able to be set by the administrators.
The migration makes a single membership type in advance which is called "Lid" (member) and everyone by default will be made member and get access to the login.
You can make additional membership types which can't login to the system at all.