Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added basic comment descriptions to the scripts and to some of the so… #27

Merged
merged 4 commits into from
Oct 15, 2017
Merged

Added basic comment descriptions to the scripts and to some of the so… #27

merged 4 commits into from
Oct 15, 2017

Conversation

babetoduarte
Copy link
Contributor

@babetoduarte babetoduarte commented Oct 14, 2017 •
edited by romanz
Loading

…urce files. There's still much to be done, but it's a start.

See #15

@babetoduarte
Added basic comment descriptions to the scripts and to some of the so…
1ff777d 
…urce files. There's still much to be done, but it's a start.
@romanz romanz self-assigned this Oct 15, 2017
@romanz romanz self-requested a review October 15, 2017 17:51
@romanz
Copy link
Owner

romanz commented Oct 15, 2017

Thanks a lot for the documentation contribution!

romanz
romanz requested changes Oct 15, 2017
View reviewed changes
Copy link
Owner

@romanz romanz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please following PEP-257 convention (mainly by moving the docstrings to the start of each source file)?

You can check that the code is PEP257 compliant by running pydocstyle amodem/.

romanz
romanz requested changes Oct 15, 2017
View reviewed changes
Copy link
Owner

@romanz romanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Please make sure that the pep8 test on Travis still passes, and I'll merge this PR.

@coveralls
Copy link

coveralls commented Oct 15, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 555186c on babetoduarte:master into 40460e0 on romanz:master.

@babetoduarte
Copy link
Contributor Author

I believe I got it! 😄

@romanz romanz merged commit 6629cb6 into romanz:master Oct 15, 2017
@romanz
Copy link
Owner

romanz commented Oct 15, 2017

Many thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanz romanz romanz requested changes

Assignees

@romanz romanz

Labels
enhancement hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babetoduarte @romanz @coveralls