-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the full open clip model name format : ViT-B-32/laion2b_s34b_b79k #314
Conversation
I think, ideally there should be a dict mapping each model to the best available checkpoint (e.g., according to imagenet zero-shot classification results), in case checkpoint is not provided. If there is no mapping in the dict, the cli should throw an error. Not sure though which models were selected before, so this might however break the run if people update the repo with this change. Maybe better to force the user to provide the checkpoint in case of an |
this would be nice. took awhile for me to figure out which open clip checkpoint actually made my embedding, and it seems the default for 'ViT-L-14' scored considerably lower than some of the other options. |
this looks similar in intent to #284 but there is no doc nor test |
2284fb4
to
6d255e1
Compare
--clip_checkpoint
option for using a specific clip checkpoint
I changed this to be like ViT-B-32/laion2b_s34b_b79k with no new arg clip checkpoint that makes it cleaner imo and does not leak the openclip interface in the top level interface of clip retrieval it allows for other clip model interfaces to have different model formats |
This leaves the defaults the same, but allow the possibility to specify a checkpoint if needed (i.e, corresponds to the
pretrained
parameter of open clip).