-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to reference external local-da kurtosis package #112
Conversation
WalkthroughThe code in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- main.star (2 hunks)
Additional comments not posted (5)
main.star (5)
1-3
: Comments updated correctly.The comments accurately reflect the new connection to a DA node instead of a local DA service.
5-5
: Module imported correctly.The
import_module
statement correctly imports the DA node module. Verify that the versionv0.3.0
is appropriate and compatible with the rest of the codebase.
12-13
: Function call updated correctly.The function
da_node.run(plan)
is correctly called and the result is assigned toda_address
. Verify thatda_node.run(plan)
is functioning as expected and returning the correct address.
15-15
: Print statement updated correctly.The
plan.print
statement correctly formats and prints theda_address
.
27-27
: Command updated correctly.The
gm_start_cmd
list correctly includes the--rollkit.da_address
argument with theda_address
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
Overview
Pending rollkit/local-da#25 and then release of local-da
Related to rollkit/rollkit#1766
Summary by CodeRabbit
local_da
toda_address
for consistency.