test: mock node rpc service #45
Conversation
WalkthroughThe project has undergone a significant update to enhance its testing capabilities. The changes include the establishment of context and new package imports, the creation and removal of test setups, and the expansion of test cases in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 0.00% 71.52% +71.52%
==========================================
Files 1 2 +1
Lines 101 144 +43
==========================================
+ Hits 0 103 +103
+ Misses 101 28 -73
- Partials 0 13 +13 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 4
Configuration used: CodeRabbit UI
Files selected for processing (3)
- celestia/celestia_test.go (1 hunks)
- celestia/mock.go (1 hunks)
- cmd/test-da/main.go (1 hunks)
Additional comments: 6
cmd/test-da/main.go (2)
- 18-36: The Cobra command setup looks correct and follows standard practices for defining a CLI application with Cobra. The use of
cobra.NoArgsensures that the command does not accept any positional arguments, which is appropriate for this command's behavior.The signal handling logic is also implemented correctly, capturing
os.Interruptandsyscall.SIGTERMto allow for a graceful shutdown of the application.
- 44-48: The error handling in the
mainfunction is appropriate. It checks if therunfunction returns an error and logs it before exiting with a non-zero status code. This is a good practice as it provides clear feedback when the application encounters an error.celestia/mock.go (2)
14-22: The
Submitmethod in theMockBlobAPIstruct correctly increments theheightand returns it. This simulates the behavior of a real blob API that would return a new height after submitting blobs.61-70: The
MockServicestruct and itsClosemethod are implemented correctly. TheClosemethod ensures that resources are released when the mock service is no longer needed, which is good practice for avoiding resource leaks during testing.celestia/celestia_test.go (2)
17-31: The
setupfunction is well-structured, creating a new mock service and asserting that no errors occur during the setup process. It also decodes a namespace and asserts the client's equality, which is a good practice to ensure the setup is correct before running tests.34-38: The
teardownfunction correctly closes the client and the mock service. This is important for releasing resources after tests are completed.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- celestia/celestia_test.go (1 hunks)
- celestia/mock.go (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- celestia/celestia_test.go
- celestia/mock.go
Overview
This PR adds unit test coverage.
Checklist
Summary by CodeRabbit