Call log_process_action so that we get status code from Devise controllers #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we will get additional payload data (e.g. Devise’s 401 status), and we are consistent with ActionController::LogSubscriber.
Could you please link to that PR for cross referencing. |
|
@oh, sure, yeah, that would help ;) heartcombo/devise#4375 |
|
Have you tried seeing if the PR in Devise fixes the problem here with no code change? |
|
This certainly feels like something better resolved upstream in devise. Can you pursue that PR? |
|
This has been resolved upstream. |
|
FYI this was reverted upstream and is still broken as of today with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #67 we're facing an issue when Devise returns a 401 status code (which is set in
log_process_action.With this change we're behaving the same as
ActionController::LogSubscriber. I don't really know if this qualifies as a workaround (and what the original intent behindlog_process_actionis/was).Please also note that there's an open PR on Devise that moves the setting of the status code from
log_process_actiontoappend_info_to_payload.