Added support for multi-server setup, enable auth token in url #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabbi
added a commit
that referenced
this pull request
Nov 15, 2024
refactored code from @cngarrison #53 Signed-off-by: Nic Boet <[email protected]>
|
Hello- I refactored your code into #69 -- had a few changes in the main branch which I couldn't auto resolve and have QA checks pass. appreciate the PR |
Draft
Thanks for getting it updated and pushing it through. Glad I could contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for multi-server setup, as well as enabling support for auth token instead of password in URLs.
Also includes fix from PR#49