fix don't emitting first "logRemoved" event #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix don't emitting event about deleting oldest file which should be emitted each time when server restarting (winstonjs/winston-daily-rotate-file#296 issue) reason in double emitting "new" event when app started, and first emit happens before stream returning and no one can hear "logRemoved" event
|
Same issue here! |
|
I've rewritten the library in Typescript. I think this is not an issue anymore as the order of events is slightly cleaner now. The new version will be released in 7 days or so. Link below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix don't emitting event about deleting oldest file which should be emitted each time when server restarting (winstonjs/winston-daily-rotate-file#296 issue)
reason in double emitting "new" event when app started, and first emit happens before stream returning and no one can hear "logRemoved" event