Add support for AIX osfamily and refactoring #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split base in config, install and defaults. * Use top-level variables that enable caller to overwrite default values. * Adds support for IBM AIX. * Use global variables instead of Linux hard-coded values.
| @@ -12,4 +12,4 @@ rotate 4 | |||
| create | |||
|
|
|||
| # packages drop log rotation information into this directory | |||
| include /etc/logrotate.d | |||
| include <%= @config_dir %> | |||
There was a problem hiding this comment.
Should be scope.lookupvar('::logrotate::config_dir').
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable our AIX hosts to use this module, I had to make some little modifications to your module.
I've tried to modify as little as possible in your code in order to make it modular and easier to maintain. I didn't modify any of your public module interface so you shouldn't have any backward compatibility issue.
What I've done is:
baseinconfig,installanddefaults.I think that this more modular design could be easier to maintain in the long term with non-Linux O.S support.
My tests were currently only done with
puppet apply ...and everything seems to work on Linux (CentOS) and AIX.I've not updated any of your tests so I expect the C.I build to fail just after this Pull Request will be created. I'd like to have first your opinion about the design I've done before going into further modifications.
I'm waiting for your point of view about this.
Cheers