Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace panic! with internal_error! in compiler/parse and compiler/can #5322

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Replace panic! with internal_error! in compiler/parse and compiler/can #5322

merged 1 commit into from
Apr 26, 2023

Conversation

jarlah
Copy link
Contributor

@jarlah jarlah commented Apr 21, 2023 •
edited
Loading

showing some love by making a little contribution.

related to #2046

@jarlah jarlah changed the title chore: replace panic! with internal_error Replace panic! with internal_error! in compiler/parse and compiler/can Apr 21, 2023
@jarlah jarlah changed the title Replace panic! with internal_error! in compiler/parse and compiler/can Replace panic! with internal_error! in <a href="https://github.com/roc-lang/roc/tree/main/crates/compiler/parse">compiler/parse</a> and compiler/can Apr 21, 2023
@jarlah jarlah changed the title Replace panic! with internal_error! in <a href="https://github.com/roc-lang/roc/tree/main/crates/compiler/parse">compiler/parse</a> and compiler/can Replace panic! with internal_error! in compiler/parse and compiler/can Apr 21, 2023
@jarlah jarlah changed the title Replace panic! with internal_error! in compiler/parse and compiler/can Replace panic! with internal_error! in [compiler/parse](https://github.com/roc-lang/roc/tree/main/crates/compiler/parse) and compiler/can Apr 21, 2023
@jarlah jarlah changed the title Replace panic! with internal_error! in [compiler/parse](https://github.com/roc-lang/roc/tree/main/crates/compiler/parse) and compiler/can Replace panic! with internal_error! in compiler/parse and compiler/can Apr 21, 2023
@jarlah jarlah changed the title Replace panic! with internal_error! in compiler/parse and compiler/can Replace panic! with internal_error! in compiler/parse and compiler/can Apr 21, 2023
folkertdev
folkertdev previously approved these changes Apr 24, 2023
View reviewed changes
@jarlah
Copy link
Contributor Author

jarlah commented Apr 24, 2023 •
edited
Loading

@folkertdev fixed bad formatting in compiler/can/src/scope.rs
EDIT: and in the parse crate ...

@jarlah jarlah requested a review from folkertdev April 24, 2023 08:18
@jarlah
Copy link
Contributor Author

jarlah commented Apr 26, 2023 •
edited
Loading

merge ? (👀)

folkertdev
folkertdev approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thanks again!

@folkertdev folkertdev merged commit 8a76937 into roc-lang:main Apr 26, 2023
@jarlah jarlah deleted the replace-panic!-with-internal-error!-in-compiler-parse-create branch April 26, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folkertdev folkertdev folkertdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarlah @folkertdev