Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to mirage>=4.7.0 #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update to mirage>=4.7.0 #14

wants to merge 1 commit into from

Conversation

reynir
Copy link
Contributor

@reynir reynir commented Oct 1, 2024

This is necessary to keep up with miragevpn changes.

@reynir
Copy link
Contributor Author

reynir commented Oct 1, 2024

I don't have a qubes setup to test it still works /o\

Copy link
Contributor

@palainp palainp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It compiles and runs find "on my laptop"(tm). I still encounter the AEAD decrypt issue, but that was already the case before :)

[2024-10-01 13:45:31] 2024-10-01T11:45:31-00:00: [ERROR] [miragevpn.mirage] miragevpn handle failed AEAD decrypt failed
[2024-10-01 13:45:31] Fatal error: exception Failure("exit called")
[2024-10-01 13:45:31] Raised at Stdlib.failwith in file "stdlib.ml", line 29, characters 17-33
[2024-10-01 13:45:31] Called from Lwt.Sequential_composition.bind.create_result_promise_and_callback_if_deferred.callback in file "duniverse/lwt/src/core/lwt.ml", line 1844, characters 16-19
[2024-10-01 13:45:31] Solo5: solo5_exit(2) called

@palainp
Copy link
Contributor

palainp commented Oct 1, 2024

hmm maybe you should also update the Dockerfile + hashsum? Github actions seem to be unactive, but a user may want to check the binary reproduction?

@palainp
Copy link
Contributor

palainp commented Oct 1, 2024

This is my current diff (the base image, debian repos, and opam have not been updated, but they can be as well if you prefer):
#15 onboards mirage-qubes update as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants