initial config_parser, using angstrom. partially hooked to the unikernel #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW the grammar description from the dnsmasq manpage is not precise: a Also note that it would be great if we can figure a path to run the examples as unit tests. May require, similar to MirageVPN, to have a library (+ alcotest suite) and separate unikernel. We'll get there. :D |
still lacks from dnsmasq some functionality, such as - using multiple dhcp ranges - netmask and broadcast aren't taken into account
|
This is ready for review. I'm happy to go through the changes in a pairing session //cc @reynir |
|
Thanks! \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @reynir (and others) for review.