console: Allow for multiple subscribers #194
Conversation
| loop | ||
| let update s = | ||
| let s = Option.value ~default:[] s in | ||
| let s' = List.filter (fun (_v, _u, fd') -> fd <> fd') s in |
There was a problem hiding this comment.
just to be sure, we can compare file descriptors? I think it is fine
There was a problem hiding this comment.
I tested with Unix.stdin = Unix.stdout and Unix.stdin = Unix.stdin. It worked fine in the toplevel. It would be nice to have somewhere to point to that says "it's safe to compare Unix.file_descras I rememberUnix.file_descr` being a bit special.
We can also have a counter that we use to generate IDs we compare with.
There was a problem hiding this comment.
I think it is fine to do. There's been here and there code to take the identifier (integer) of a fd -- but I guess we don't need that nor want to go down that route.
It'd indeed be nice if there was a Unix.compare_fd or Unix.equal_fd function provided by OCaml.
No description provided.