stats: /proc/pid/status parsing more flexible #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Oct 7, 2024
CHANGES: * Albatross-daemon: discover and provide root policy with the available system resources (robur-coop/albatross#190 @hannesm @reynir @PizieDust) * Vmm_core.Policy.usable: check that block size, if present, is non-negative (robur-coop/albatross#192 @hannesm) * BREAKING: rename vm to unikernel (robur-coop/albatross#192 @hannesm) * Document Vmm_trie (robur-coop/albatross#192 @hannesm) * Parse /proc/pid/status less strict (robur-coop/albatross#193 @Firobe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/proc/<pid>/statuscan have empty values, which were refused by the parsing function. For example on my machine (the separating tabs are still present):Furthermore, and even though no values other than
non/voluntary_ctxt_switchesare used for now, other lines have further leading whitespace (seemingly to align values for humans to read), likeVmPeak.Swap to using
String.triminstead of doing it manually, accounting for all cases