fixing some issues #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
typemytype
commented
Feb 1, 2016
typemytype
commented
- typo: setCmap --> setCMAP
- add call super in Font object
- return fallback glyph when the name is not in the glyph set
- support for begin end processing of GSUB and GPOS
- typo: setCmap --> setCMAP - add call super in Font object - return fallback glyph when the name is not in the glyph set - support for begin end processing of GSUB and GPOS
|
this solves issues posted here #14 |
|
The change to the GSUB and GPOS processing sequence won't solve the problem completely. I'll merge this and leave that change until I have time to work up a full fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.