os/impl/LogForwarder: Do not use a static Bottle #2667
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdanz
added
Component: Library - YARP_os
PR Type: Bugfix
This comment has been minimized.
This comment has been minimized.
When the `forward` method is called twice, the `Bottle::clear()` method could be called before the message is sent, hence deleting the bottle being sent. This fixes the `LogForwarder` skipping messages when messages are sent too quickly (Fixes robotology#2643).
drdanz
force-pushed
the
LogForwarder_static_Bottle
branch
from
6f6c64e
to
63a1e8e
Compare
|
This PR is temporarily blocked, since this will block the sender when there are 2 messages in queue, and at the moment there is no way to avoid this, or to make the queue bigger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
forwardmethod is called twice, theBottle::clear()method could be called before the message is sent, hence deleting the bottle being sent.This fixes the
LogForwarderskipping messages when messages are sent too quickly (Fixes #2643).Libraries
osLogForwarderno longer skips messages when messages are sent tooquickly (Yarplogger may not report all entries #2643).