Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MuJoCo Menagerie model for gen3_mj_description #93

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

kevinzakka
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9714466205

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.54%

Totals Coverage Status
Change from base Build 9694182113: 0.02%
Covered Lines: 912
Relevant Lines: 935

💛 - Coveralls

@stephane-caron
Copy link
Member

Can you confirm this description is a better fit for MuJoCo than kinova_mj_description? If so, we could update gen3_mj_description to avoid a duplicate.

On a side note, currently we don't include robot maker names in description identifiers, just robot names (from CONTRIBUTING.md: "The file name for the new submodule is <robot_name>_description.py in snake-case."). It has not happened yet that different makes use the same robot name 😅

@kevinzakka
Copy link
Contributor Author

Hi @stephane-caron, apologies for the delayed response. I can confirm that the Menagerie model is a better fit for a few reasons. Main one is that it is actively being used and maintained by collaborators at Stanford.

@kevinzakka kevinzakka changed the title Add Kinova Gen3 MJCF description. Use MuJoCo Menagerie model for gen3_mj_description Jul 20, 2024
@kevinzakka
Copy link
Contributor Author

FYI, there is no "gen3 jaco" model, jaco was the previous iteration. Should be updated for the non MuJoCo models as well.

@coveralls
Copy link

coveralls commented Jul 20, 2024

Pull Request Test Coverage Report for Build 10044955281

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.524%

Totals Coverage Status
Change from base Build 10044927097: 0.0%
Covered Lines: 906
Relevant Lines: 929

💛 - Coveralls

@stephane-caron stephane-caron merged commit dd4ad7a into robot-descriptions:main Jul 22, 2024
11 checks passed
stephane-caron added a commit that referenced this pull request Jul 22, 2024
stephane-caron added a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants