Do not prevent default if the element that triggers is a checkbox.

rmariuzzo · May 15, 2014 · f2f4df1 · f2f4df1
1 parent 896d609
commit f2f4df1
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/build/jquery.checkboxes.min.js b/build/jquery.checkboxes.min.js
diff --git a/src/jquery.checkboxes.js b/src/jquery.checkboxes.js
@@ -1,4 +1,6 @@
-/*! Checkbox.js - MIT - Rubens Mariuzzo */ ! function($) {
+/*! Checkbox.js - MIT - Rubens Mariuzzo */ 
+
+! function($) {
 
     //////////////////////////////////
     /* Checkboxes class definition. */
@@ -128,7 +130,9 @@
             $context = $(el.data('context') || (href && href.replace(/.*(?=#[^\s]+$)/, ''))),
             action = el.data('action');
         if ($context && action) {
-            e.preventDefault();
+            if (!el.is(':checkbox')) {
+                e.preventDefault();
+            }
             $context.checkboxes(action);
         }
     });

diff --git a/test/test.html b/test/test.html
@@ -47,5 +47,12 @@
     <a href="#checkboxes" 
 	    data-toggle="checkboxes"
 	    data-action="uncheck">Uncheck all</a>
+	<label>
+		<input type="checkbox"
+			data-context="#checkboxes"
+			data-toggle="checkboxes"
+		    data-action="toggle">
+		Check all
+	</label>
 </body>
 </html>