Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature #104660900 haikus index view #22

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on Oct 25, 2015

  1. start react-rails setup

        bundle "react-rails" gem
        rails generate react:install
          app/assets/javascripts/application.js
          app/assets/javascripts/components.js
          app/assets/javascripts/components
    kangkyu committed Oct 25, 2015
    Configuration menu
    Copy the full SHA
    0fb84a3 View commit details
    Browse the repository at this point in the history
  2. Add haikus#index page in React JSX

    app/controllers/haikus_controller.rb
    app/assets/javascripts/components/Haiku.js.jsx
    app/assets/javascripts/components/Haikus.js.jsx
    app/views/layouts/application.html.erb
    
    Edit the seeds file to create haikus with its three lines
    db/seeds.rb
    kangkyu committed Oct 25, 2015
    Configuration menu
    Copy the full SHA
    2ca7d19 View commit details
    Browse the repository at this point in the history
  3. Start Skeleton CSS setup

    add normalize.css skeleton.css file and require them
    import Raleway font
    
    app/assets/stylesheets/application.css
    app/assets/stylesheets/normalize.css
    app/assets/stylesheets/skeleton.css
    app/views/layouts/application.html.erb
    
    apply its container class to layout template
    kangkyu committed Oct 25, 2015
    Configuration menu
    Copy the full SHA
    c11c315 View commit details
    Browse the repository at this point in the history
  4. Add pagination - bundle Kaminari gem

    find page by "?page=" parameter params[:page]
    install config file
    
    app/controllers/haikus_controller.rb
    config/initializers/kaminari_config.rb
    kangkyu committed Oct 25, 2015
    Configuration menu
    Copy the full SHA
    176e21a View commit details
    Browse the repository at this point in the history
  5. paginate at 10

    kangkyu committed Oct 25, 2015
    Configuration menu
    Copy the full SHA
    b8732d4 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2015

  1. add format: :json and pass haikus_spec test

    code of problem was app/controllers/haikus_controller.rb #index method
    modified:   spec/requests/haikus_spec.rb
    kangkyu committed Oct 28, 2015
    Configuration menu
    Copy the full SHA
    fef8d47 View commit details
    Browse the repository at this point in the history