Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fill input with selected value #52

Merged

Conversation

PatrickDesign
Copy link
Collaborator

@PatrickDesign PatrickDesign commented Dec 10, 2020

Fix a bug where we were not using the correct variable to set the input value upon selection.

Document maxResults - answers part of #18.

Closes #25

@PatrickDesign PatrickDesign changed the title [FEATURE] Fill input with selected value [BUGFIX] Fill input with selected value Dec 10, 2020
@PatrickDesign PatrickDesign force-pushed the patrickW/feature--add-isFilter-prop branch from 381c1a4 to 18bcc36 Compare December 10, 2020 22:37
@PatrickDesign PatrickDesign force-pushed the patrickW/feature--fill-input-with-selected-value branch from 8f29017 to dc36044 Compare December 10, 2020 22:38
@PatrickDesign PatrickDesign force-pushed the patrickW/feature--add-isFilter-prop branch from 18bcc36 to 8f0fbf8 Compare December 16, 2020 22:28
@PatrickDesign PatrickDesign force-pushed the patrickW/feature--fill-input-with-selected-value branch from dc36044 to 8284b1e Compare December 16, 2020 22:28
@PatrickDesign PatrickDesign force-pushed the patrickW/feature--add-isFilter-prop branch from 8f0fbf8 to 27ffae4 Compare December 16, 2020 22:29
@PatrickDesign PatrickDesign force-pushed the patrickW/feature--fill-input-with-selected-value branch from 8284b1e to e79247f Compare December 16, 2020 22:29
@PatrickDesign PatrickDesign force-pushed the patrickW/feature--add-isFilter-prop branch from 27ffae4 to 5064727 Compare December 16, 2020 22:34
@PatrickDesign PatrickDesign force-pushed the patrickW/feature--fill-input-with-selected-value branch from e79247f to 4fe50e9 Compare December 16, 2020 22:34
@PatrickDesign PatrickDesign changed the base branch from patrickW/feature--add-isFilter-prop to master December 17, 2020 22:56
PatrickDesign and others added 2 commits December 17, 2020 15:00
Co-authored-by: master-elodin <[email protected]>
Avoid using `action` within the sample code, as it caused some
confusion with non-redux users. (#10)
@PatrickDesign PatrickDesign force-pushed the patrickW/feature--fill-input-with-selected-value branch from 4fe50e9 to 0f76849 Compare December 17, 2020 23:03
I noticed this prop was not documented when reading #18.
@PatrickDesign PatrickDesign merged commit 97f92a6 into master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click does not set input value
2 participants