135 add stack account self service features #150
Conversation
There was a problem hiding this comment.
Overall, solid PR and I've very excited for the feature!
However, I think we should have a discussion on the best approach to use when interacting with the Openstack API (launching an external script versus REST API calls directly or through a GO package).
For now, I'm going to put Request changes on this, but great job so far!
| OS_INTERFACE string = config.GetString("openstack.ENV.OS_INTERFACE") | ||
| OS_IDENTITY_API_VERSION string = config.GetString("openstack.ENV.OS_IDENTITY_API_VERSION") | ||
|
|
||
| // Paths for scripts to automate openstack user management |
There was a problem hiding this comment.
Just curious, is there a reason why you went with executing a script versus using an Openstack GO SDK? I'm wondering if that might be a better approach when it comes to error handling and dependencies (now you would need to ensure the Openstack CLI is setup on the running machine)
There was a problem hiding this comment.
I also just noticed that the scripts are not checked into the repo. Thoughts on including those?
There was a problem hiding this comment.
Just curious, is there a reason why you went with executing a script versus using an Openstack GO SDK?
Not gonna lie, I did not think about a GO package for interacting with Openstack API. I should have checked if there is one out of there. I will look into it and see if I can implement it.
I also just noticed that the scripts are not checked into the repo. Thoughts on including those?
Sure, no problem.
| } | ||
|
|
||
| // Initialize the environment variables for Openstack CLI | ||
| SetOpenstackRC() |
There was a problem hiding this comment.
Since these variables are initially stored in the OBIII config file, I'd probably move this to the main.go file as it can be seen as redundant to keep setting these on every Openstack command. However, I do see the argument where the host's environment variables could get overwritten after OBIII's initial startup
There was a problem hiding this comment.
Depending on gophercloud's implementation, I may or may not need it but in case if I do, I will move it to main.go.
Things to update locally once this is merged: