Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(meta): batch delete time travel metadata #20169

Merged
merged 1 commit into from
Jan 16, 2025
Merged

refactor(meta): batch delete time travel metadata #20169

merged 1 commit into from
Jan 16, 2025
+27 −5

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jan 15, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR enables the deletion of SSTable info metadata from multiple delta logs in a single meta store request.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@zwang28 zwang28 requested a review from Li0k January 15, 2025 03:56
@zwang28 zwang28 force-pushed the wangzheng/refactor_2 branch from 5ff3bfb to 89bfb44 Compare January 15, 2025 03:58
@zwang28 zwang28 enabled auto-merge January 15, 2025 03:58
Li0k
Li0k approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang28 zwang28 added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit bc429d5 Jan 16, 2025
36 of 37 checks passed
@zwang28 zwang28 deleted the wangzheng/refactor_2 branch January 16, 2025 09:10
github-actions bot pushed a commit that referenced this pull request Jan 16, 2025
@zwang28
refactor(meta): batch delete time travel metadata (#20169)
94189ed
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 16, 2025
@zwang28
refactor(meta): batch delete time travel metadata (#20169)
e8b4c32
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Open
github-merge-queue bot pushed a commit that referenced this pull request Jan 21, 2025
@github-actions @zwang28 @cyliu0
refactor(meta): batch delete time travel metadata (#20169) (#20183)
e2d2505 
Co-authored-by: zwang28 <[email protected]>
Co-authored-by: Chengyou Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Li0k Li0k Li0k approved these changes

Assignees
No one assigned
Labels
ci/run-e2e-single-node-tests ci/run-e2e-test-other-backends need-cherry-pick-release-2.1 need-cherry-pick-release-2.2 type/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwang28 @Li0k