-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: optimize delta log deletion #20158
Conversation
3a28281
to
274fd27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM, thanks for the PR
// If there is any safe point, skip this to ensure meta backup has required delta logs to | ||
// replay version. | ||
if !context_info.version_safe_points.is_empty() { | ||
return Ok((0, deltas_to_delete_count)); | ||
return Ok(0); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An implicit problem may cause the request to time out if the number of bulk deletions is too large.
Optional Handling Means
- Stop the service
- Log in to pg and actively clean it up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for the record, as we think its probability is low.
(cherry picked from commit d00c6e3)
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Since compatibility with the etcd meta store is no longer necessary, delta log deletion can now be performed with a single SQL query.
Checklist
Documentation
Release note