-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make privatelink.endpoint
accept json array
#20154
base: main
Are you sure you want to change the base?
Conversation
link_targets: &[AwsPrivateLinkItem], | ||
broker_addrs: &[&str], | ||
) -> ConnectorResult<()> { | ||
let endpoint = if let Ok(json) = serde_json::from_str::<serde_json::Value>(endpoint) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we introduce a potential risk is if the user input an illegal json, which cannot be parsed, we will see it as a string, instead of returning error. The case seems acceptable to me because he cannot connect to the broker using the wrong endpoint addr and he will find out later.
convert to draft for now as the poc user does not need it. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
resolve cloud issue
Checklist
Documentation
Release note