Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): refactor and support local state store flushed snapshot reader #20153

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Jan 14, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously in the sink log store, for log reader, we use methods in StateStore to access the data flushed by log writer. Methods in StateStore will read all shards (aka HummockReadVersion) of the table_id on the same CN. However, since the log reader is always in the same SinkExecutor as log writer, it actually only needs to read the shard that belongs to the writer, and using StateStore will unnecessarily read more unrelated data.

In this PR, we will add a new method new_flushed_snapshot_reader to LocalStateStore, whose return type is a new associated type FlushedSnapshotReader that should implement the StateStoreRead trait.

pub trait LocalStateStore: StaticSendSync {
    type FlushedSnapshotReader: StateStoreRead + Clone;
   ...

    fn new_flushed_snapshot_reader(&self) -> Self::FlushedSnapshotReader;
}

The semantic of this new FlushedSnapshotReader is, it can read the uncommitted data written by the parent LocalStateStore as long as the data has been flusheed by the parent LocalStateStore. Such FlushedSnapshotReader will only read the same shard as the local state store.

The KvLogStoreReader will change to use this FlushedSnapshotReader to read to avoid reading unnecessary data in other shards in the CN.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants