Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nan/inf/-inf as float/double default #4

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

xiangjinwu
Copy link
Collaborator

@xiangjinwu xiangjinwu commented Jun 18, 2024

match default_datum {
Value::Double(f) if f.is_nan() => {
let Value::Record(fields) = datum_read else {
panic!()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you write a meaningful error in this panic?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is guaranteed to be record by the testing setup itself. I have updated it to unreachable

@xiangjinwu xiangjinwu merged commit 25113ba into risingwave-patched-rebase-0.16.0 Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants