Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(array,types): support vector type #866

Merged
merged 2 commits into from
Jan 16, 2025
Merged

feat(array,types): support vector type #866

merged 2 commits into from
Jan 16, 2025

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jan 8, 2025 •
edited
Loading

xxchan
xxchan reviewed Jan 8, 2025
View reviewed changes
src/array/bytes_array.rs Outdated Show resolved Hide resolved
@skyzh skyzh requested a review from xxchan January 8, 2025 04:16
@skyzh skyzh mentioned this pull request Jan 11, 2025
Merged
skyzh and others added 2 commits January 11, 2025 15:33
@skyzh
feat(array,types): support vector type
40b7383 
Signed-off-by: Alex Chi Z <[email protected]>

fix clippy + rename

Signed-off-by: Alex Chi Z <[email protected]>

new_in_memory

Signed-off-by: Alex Chi Z <[email protected]>

fix tests

Signed-off-by: Alex Chi Z <[email protected]>
@skyzh
feat(eval): support vector ops (#867)
728bd32 
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh mentioned this pull request Jan 11, 2025
Open
@skyzh
Copy link
Member Author

skyzh commented Jan 16, 2025

(ping for reviews, thanks)

wangrunji0408
wangrunji0408 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 4144c89 Jan 16, 2025
5 checks passed
@wangrunji0408 wangrunji0408 deleted the skyzh/vector branch January 16, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangrunji0408 wangrunji0408 wangrunji0408 approved these changes

@TennyZhuang TennyZhuang Awaiting requested review from TennyZhuang

@xxchan xxchan Awaiting requested review from xxchan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skyzh @wangrunji0408 @xxchan