fallback to overview.html when pages do not exist for compare option

rishijain · Oct 16, 2023 · c55ca22 · c55ca22
1 parent 1d20e4f
commit c55ca22
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 * [CHANGE] Fix test warning related to `cucumber_opts` declaration (by [@faisal][])
 * [BUGFIX] Stop using long-deprecated MiniTest module name, removed in 5.19.0 (by [@faisal][])
 * [CHANGE] Disable VERBOSE warnings in test stubs (by [@fbuys][])
+* [BUGFIX] Use overview.html as the fallback path when files does not exist during compare option (by [@rishijain][])
 
 # v4.8.1 / 2023-05-17 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.8.0...v4.8.1)
 

diff --git a/lib/rubycritic/generators/html/view_helpers.rb b/lib/rubycritic/generators/html/view_helpers.rb
@@ -24,7 +24,10 @@ def smell_location_path(location)
     end
 
     def code_index_path(root_directory, file_name)
-      file_path("#{File.expand_path(root_directory)}/#{file_name}")
+      root_directory_path = File.expand_path(root_directory)
+      file_path = "#{root_directory_path}/#{file_name}"
+      file_path = "#{root_directory_path}/overview.html" unless File.exist?(file_path)
+      file_path(file_path)
     end
 
     private