Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types #21

Merged
merged 3 commits into from
Aug 4, 2024
Merged

Conversation

florian-lefebvre
Copy link
Contributor

According to https://stackoverflow.com/questions/61047551/typescript-union-of-string-and-string-literals, the right type to allow any string is not the one I initially suggested. It works but since there's a better way, here is a quick PR for it! cc @rishi-raj-jain

@rishi-raj-jain
Copy link
Owner

Thank you for taking the time and energy to make the PRs 🤍

@rishi-raj-jain rishi-raj-jain merged commit e2ccf73 into rishi-raj-jain:master Aug 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants