target/riscv: avoid unnecessary dcsr.ebreak* update on reset
#1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zqb-all
reviewed
Oct 25, 2024
src/target/riscv/riscv-013.c
Outdated
| static bool dcsr_ebreak_config_equals_reset_value(const struct target *target) | ||
| { | ||
| RISCV_INFO(r); | ||
| return !(r->riscv_ebreakm || r->riscv_ebreaks || r->riscv_ebreaks); |
There was a problem hiding this comment.
Duplicate riscv_ebreaks, should be riscv_ebreaku.
There was a problem hiding this comment.
Huge thanks for the catch!
There is no need to change if `dcsr.ebreak*` fields after a reset if a user requested a configuration that will result `dcsr.ebreak*` field values equal to reset values. Change-Id: I2844d30aef8f735c7b37394ee422e9b3f04a2e3b Signed-off-by: Evgeniy Naydanov <[email protected]>
en-sc
force-pushed
the
en-sc/dcsr-ebreak-halt-on-reset
branch
from
8b844f3
to
3fe20e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to change if
dcsr.ebreak*fields after a reset if a user requested a configuration that will resultdcsr.ebreak*field values equal to reset values.Change-Id: I2844d30aef8f735c7b37394ee422e9b3f04a2e3b