-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gcc into 14.2 release version. #1531
Conversation
I guess that this PR renders the following one moot/redundant? |
test/allowlist/gcc/glibc.log
Outdated
# RV64 fail case | ||
# | ||
FAIL: gcc.dg/tree-prof/time-profiler-2.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC it's a random fail case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check it again :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reproduced the fail case, move it into glibc.rv64.log
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also appeared in https://github.com/riscv-collab/riscv-gnu-toolchain/actions/runs/10380519463/job/28740484185?pr=1531
Move it into glibc.log
.
test/allowlist/gcc/glibc.log
Outdated
# Fixed but not backport | ||
# | ||
FAIL: gcc.dg/tree-prof/time-profiler-2.c | ||
UNRESOLVED: gcc.target/riscv/rvv/autovec/vls-vlmax/full-vec-move1.c | ||
FAIL: gcc.target/riscv/rvv/autovec/vls-vlmax/full-vec-move1.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, could you point me which commit fix that? so that I could backport that and we will have fix on 14.3...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=b1520d2260c5e0cfcd7a4354fab70f66e2912ff2,
I compared the trunk https://gcc.gnu.org/git/?p=gcc.git&a=search&h=HEAD&st=commit&s=full-vec-move1.c
with the gcc14.2 release tree https://gcc.gnu.org/git/?p=gcc.git&a=search&h=04696df09633baf97cdbbdd6e9929b9d472161d3&st=commit&s=full-vec-move1.c
ack, I am running regression on my machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
I'm running a multilib build locally right now (with this PR on top of the other update PRs for binutils, qemu, glibc, and gdb). |
I got the following errors:
Failing tests are:
Some of the fortran tests have been removed in this PR. |
Verified on
Reproduced in the corresponding arch-abi combination, show execution errors, maybe they are qemu issues.
The follow fail cases not reproduced, could you check these tests' log, thanks!
|
We don't need to analyze the root cause.
The Python stuff looks very strange.
This is probably a regression (I wonder why you cannot reproduce):
|
Agree.
I checked the output log, these python cases were marked as unsupported on my machine, maybe it relative to local python version. Anyway, these cases really fail and I will add them to list in next commit.
I'm not sure, local log show it passed, and I check on godbolt it was found 3 times 'Generated FMA'
|
Re-added the python and gfortan fail cases into allowlist, b2ffbd2 @cmuellner please re-check |
Hmmm, still not clean on my hand yet, but very close now:
This also fail on my machine as well...?
And I have this line on my every g++ testsuite, but this may just my env issue. |
Same here:
|
It seems because lack of floating point support, this won't generate any FMA after you adding "-march=rv32imac -mabi=ilp32" |
Thanks for your work, updated it with new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
|
Jiawei, thank you very much for bringing this over the finish line! |
Hi |
Bump gcc into 14.2.0 release version, update the allowlist.