Added ShardArchiver.py utility: #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShardArchiver is a command line utility that creates lz4 compressed tar archives from complete shards and optionally transfers them to a remote server.
miguelportilla
force-pushed
the
shard-archiver
branch
from
df7194c to
45e3012
Compare
seelabs
reviewed
Aug 27, 2018
| # OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. | ||
|
|
||
| # Creates lz4 compressed tar archives from complete | ||
| # shards and optinally SCP transfers to a destination |
There was a problem hiding this comment.
This would make a good module level doc string (i.e. just make it a string: '''Create lz4 compressed archives...
| # shards and optinally SCP transfers to a destination | ||
|
|
||
| import lz4.frame | ||
| import os |
|
|
||
|
|
||
| def create_lz4(source_file, output_path): | ||
| src = open(source_file, mode='rb') |
There was a problem hiding this comment.
I'd use a with statement here for src
| f.write(piece) | ||
|
|
||
|
|
||
| def process(args): |
There was a problem hiding this comment.
I'd give the arguments individual names rather than just passing in args. If the argument is optional (as with indenty_file, username, host, and host_directory), just default them to None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShardArchiver is a command line utility that creates lz4
compressed tar archives from complete shards and optionally
transfers them to a remote server.