fixes riot/riot#2902

riot · Apr 5, 2021 · a77e32b · a77e32b
1 parent 9809d97
commit a77e32b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/expressions/attribute.js b/src/expressions/attribute.js
@@ -38,7 +38,7 @@ function removeAllAttributes(node, newAttributes, oldAttributes) {
  * @returns {boolean} true if we can render this attribute value
  */
 function canRenderAttribute(value) {
-  return value === true || typeof value === 'string'
+  return value === true || ['string', 'number'].includes(typeof value)
 }
 
 /**

diff --git a/test/expressions/attribute.spec.js b/test/expressions/attribute.spec.js
@@ -31,6 +31,20 @@ describe('attribute specs', () => {
     expect(p.selected).to.be.ok
   })
 
+  it('number attributes will be rendered', () => {
+    const target = document.createElement('div')
+    template('<p expr0></p>', [{
+      selector: '[expr0]',
+      expressions: [
+        { type: expressionTypes.ATTRIBUTE, name: 'class', evaluate: scope => scope.attr }
+      ]
+    }]).mount(target, { attr: 1 })
+
+    const p = target.querySelector('p')
+
+    expect(p.getAttribute('class')).to.be.equal('1')
+  })
+
   it('remove attribute if it\'s falsy', () => {
     const target = document.createElement('div')
     template('<p class="hello" expr0></p>', [{