updated: improved loop performance

riot · Jun 2, 2019 · 3741c10 · 3741c10
1 parent e389ec2
commit 3741c10
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/dist/esm.dom-bindings.js b/dist/esm.dom-bindings.js
@@ -685,7 +685,9 @@ function patch(redundant, parentScope) {
   return (item, info) => {
     if (info < 0) {
       const {template, context} = redundant.pop();
-      template.unmount(context, parentScope, false);
+      // notice that we pass null as last argument because
+      // the root node and its children will be removed by domdiff
+      template.unmount(context, parentScope, null);
     }
 
     return item
@@ -1487,7 +1489,7 @@ const TemplateChunk = Object.freeze({
 
       if (mustRemoveRoot && this.el.parentNode) {
         this.el.parentNode.removeChild(this.el);
-      } else {
+      } else if (mustRemoveRoot !== null) {
         cleanNode(this.el);
       }
 

diff --git a/dist/umd.dom-bindings.js b/dist/umd.dom-bindings.js
@@ -691,7 +691,9 @@
     return (item, info) => {
       if (info < 0) {
         const {template, context} = redundant.pop();
-        template.unmount(context, parentScope, false);
+        // notice that we pass null as last argument because
+        // the root node and its children will be removed by domdiff
+        template.unmount(context, parentScope, null);
       }
 
       return item
@@ -1493,7 +1495,7 @@
 
         if (mustRemoveRoot && this.el.parentNode) {
           this.el.parentNode.removeChild(this.el);
-        } else {
+        } else if (mustRemoveRoot !== null) {
           cleanNode(this.el);
         }
 

diff --git a/src/bindings/each.js b/src/bindings/each.js
@@ -75,7 +75,9 @@ function patch(redundant, parentScope) {
   return (item, info) => {
     if (info < 0) {
       const {template, context} = redundant.pop()
-      template.unmount(context, parentScope, false)
+      // notice that we pass null as last argument because
+      // the root node and its children will be removed by domdiff
+      template.unmount(context, parentScope, null)
     }
 
     return item

diff --git a/src/template.js b/src/template.js
@@ -89,7 +89,7 @@ export const TemplateChunk = Object.freeze({
 
       if (mustRemoveRoot && this.el.parentNode) {
         this.el.parentNode.removeChild(this.el)
-      } else {
+      } else if (mustRemoveRoot !== null) {
         cleanNode(this.el)
       }