Skip to content

Commit

Permalink
deps: Remove dependency on @angular/bazel. (tensorflow#5774)
Browse files Browse the repository at this point in the history
Removes the unused dependency on the npm package @angular/bazel.

The rules_nodejs documentation actually has recommended against its use:
https://github.com/bazelbuild/rules_nodejs/releases/tag/2.0.0

`For most applications, we no longer recommend depending on the @angular/bazel package. The only rule needed from it was ng_module which you can replace with the faster equivalent ts_library(use_angular_plugin=True)`

We transitioned from ng_module to ts_library(use_angular_plugin=True) in tensorflow#4376.

Steps to complete:
1. `yarn remove @angular/bazel`
2. Run the following commands: `bazel clean --expunge`, `rm -rf node_modules`, `yarn`
3. Build and run tensorboard and manually inspect it works.
4. Build and run tensorboard angular tests.
  • Loading branch information
bmd3k authored Jun 24, 2022
1 parent 6f59980 commit 26161ee
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 228 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
},
"homepage": "https://github.com/tensorflow/tensorboard#readme",
"devDependencies": {
"@angular/bazel": "12.2.0",
"@angular/cli": "^12.2.0",
"@angular/compiler": "^12.2.0",
"@angular/compiler-cli": "^12.2.0",
Expand Down
Loading

0 comments on commit 26161ee

Please sign in to comment.