-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include gate and measurement noise #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue has an empty description and so does this MR so I'm not sure how to approach it, but it appears that there were a couple other args that can be threaded through the FFI layer and that does that here, with a single test?
Is there a pattern we could use to avoid breaking changes when arguments are changed - like a builder pattern? so qvm_multishot
remains stable over time without breaking changes like this PR
I intended to open this as a draft MR. Not sure why sometimes draft is the default and other times it is not. |
I had discussed this with folks a while back, e.g. changing |
This MR