Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include gate and measurement noise #45

Merged
merged 4 commits into from
Nov 16, 2023
Merged

fix: include gate and measurement noise #45

merged 4 commits into from
Nov 16, 2023

Conversation

notmgsk
Copy link
Contributor

@notmgsk notmgsk commented Nov 15, 2023

This MR

  • adds the required gate and measurement noise parameters
  • updates the README

Copy link

@kalzoo kalzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue has an empty description and so does this MR so I'm not sure how to approach it, but it appears that there were a couple other args that can be threaded through the FFI layer and that does that here, with a single test?

Is there a pattern we could use to avoid breaking changes when arguments are changed - like a builder pattern? so qvm_multishot remains stable over time without breaking changes like this PR

examples/qvm/multishot.c Outdated Show resolved Hide resolved
examples/qvm/multishot.c Outdated Show resolved Hide resolved
examples/qvm/multishot.c Show resolved Hide resolved
@notmgsk
Copy link
Contributor Author

notmgsk commented Nov 16, 2023

The issue has an empty description and so does this MR so I'm not sure how to approach it, but it appears that there were a couple other args that can be threaded through the FFI layer and that does that here, with a single test?

I intended to open this as a draft MR. Not sure why sometimes draft is the default and other times it is not.

@notmgsk
Copy link
Contributor Author

notmgsk commented Nov 16, 2023

Is there a pattern we could use to avoid breaking changes when arguments are changed - like a builder pattern? so qvm_multishot remains stable over time without breaking changes like this PR

I had discussed this with folks a while back, e.g. changing multishot(program, addresses, num_trials, NULL, NULL, &result) to multishot(request, &result) but had difficulty making that work in an ergonomic way. (If everything was in C, it would've been fairly simple, but handing that to (or back from) Lisp was more complicated.) It's also typical, if unsightly, to see C functions like this with many arguments. On the Rust side, it is much easier for us to use a builder pattern. From a BC perspective, I think this is the only incompatibility.

@notmgsk notmgsk merged commit 5e5ae16 into main Nov 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants