This repository has been archived by the owner on Jun 6, 2021. It is now read-only.
Add FCM Support #161
Open
Add FCM Support #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oser.json in the first place.
ksami007
suggested changes
Dec 29, 2017
| * | ||
| * @var array | ||
| */ | ||
| protected $gcmOptions = array(); | ||
| protected $fcmOptions = array(); | ||
|
|
||
| /** | ||
| * Sets the string message |
There was a problem hiding this comment.
Hello,
In the FCM case setMessage method will not work :) it should be replaced by body attribute. We can add also "title" attribute.
public function setMessage($message) { if ($this->isFCM){ $this->body = $message; } else { $this->message = $message; } }
There was a problem hiding this comment.
Ah! Good catch. Thanks. I'll get that fixed shortly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I realized after I forked and made these changes that a PR was already open (#141), but it was in need of review. I went ahead and made the changes that were mentioned in the comments.
I also made additional formatting changes to comply with Symfony and PSR-2 standards.
This applies to issues #160 and #140 .