Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

Added sort and sort_order to getCollectionItemsByFolder in service.php #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added sort and sort_order to getCollectionItemsByFolder in service.php #53

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79324c0
Added sort and sort_order to getCollectionItemsByFolder in service.php
Mar 2, 2019
303f1a4
Fixed indention on sort array.
Mar 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions resources/service.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,16 @@
'type' => 'string',
'location' => 'query',
'required' => false
],
'sort' => [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much indentation here

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a testcase for these new parameters?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

'type' => 'string',
'location' => 'query',
'required' => false
],
'sort_order' => [
'type' => 'string',
'location' => 'query',
'required' => false
]
]
]
Expand Down